fix: properly handle repository name and PR number in GitHub API calls

Co-Authored-By: Michael Latman <[email protected]>
michaellatman · Dec 11, 2024 · b0adcaf · b0adcaf
1 parent f100ec7
commit b0adcaf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -44,6 +44,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GITHUB_REPOSITORY: ${{ github.repository }}
           GITHUB_REPOSITORY_OWNER: ${{ github.repository_owner }}
+          GITHUB_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
 
       - name: Provide feedback
         if: always()

diff --git a/src/scripts/pr-check.js b/src/scripts/pr-check.js
@@ -165,8 +165,8 @@ async function validateEnvironmentVariables(pkg) {
 async function provideFeedback(newPackages) {
   const { data: pullRequest } = await octokit.pulls.get({
     owner: process.env.GITHUB_REPOSITORY_OWNER,
-    repo: process.env.GITHUB_REPOSITORY,
-    pull_number: process.env.GITHUB_PULL_REQUEST_NUMBER
+    repo: process.env.GITHUB_REPOSITORY.split('/')[1],
+    pull_number: parseInt(process.env.GITHUB_PULL_REQUEST_NUMBER, 10)
   });
 
   const feedback = newPackages.length > 0
@@ -175,7 +175,7 @@ async function provideFeedback(newPackages) {
 
   await octokit.issues.createComment({
     owner: process.env.GITHUB_REPOSITORY_OWNER,
-    repo: process.env.GITHUB_REPOSITORY,
+    repo: process.env.GITHUB_REPOSITORY.split('/')[1],
     issue_number: pullRequest.number,
     body: feedback
   });