Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance PR validation checks #37

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

This PR enhances the automated validation checks for MCP packages.

Changes

  • Add JSON formatting validation

    • Consistent indentation (2 spaces)
    • Proper comma placement
    • Valid JSON structure
  • Add Python package validation

    • Check uvx registry for Python packages
    • Configure pip for uvx in workflow
    • Validate runtime field
  • Add environment variable validation

    • Check helper file documentation
    • Verify required/optional status
    • Validate description presence
  • Enhance metadata validation

    • URL format validation
    • Runtime field validation
    • Complete field presence check

Testing

  • Tested with existing packages
  • Verified JSON formatting checks
  • Confirmed env var validation
  • Tested package registry checks

Link to Devin run: https://app.devin.ai/sessions/8f2357a02a9a404596469e6b4a2590a3

devin-ai-integration bot and others added 4 commits December 11, 2024 06:18
- Add JSON formatting and style validation
- Add Python package (uvx) publication check
- Add environment variable documentation validation
- Add URL format validation
- Add runtime validation
- Update workflow for Python support

Co-Authored-By: Michael Latman <[email protected]>
- Add better error messages and logging
- Fix uvx package validation using pip install --dry-run
- Improve JSON formatting validation
- Add PR status emoji feedback
- Fix pip configuration for uvx registry

Co-Authored-By: Michael Latman <[email protected]>
Copy link
Contributor

❌ PR validation failed. Please check the workflow logs for details.

Copy link
Contributor

❌ PR validation failed. Please check the workflow logs for details.

Copy link
Contributor

No new packages were added in this PR.

Copy link
Contributor

✅ PR validation passed successfully!

Copy link
Contributor

❌ No new packages found or validation failed.

Copy link
Contributor

✅ PR validation passed successfully!

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@michaellatman michaellatman merged commit 244d9e8 into main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant