Removed composables from unstable composables baseline (Ivy-Apps#2967)

* Removed composables from unstable composables baseline

* Made the composable function IconsRow() paramaters stable

* Revert "Made the composable function IconsRow() paramaters stable"

This reverts commit 2a93c72.

* Marked ComposeViewModel as Stable

* Marked All Implementations of ComposeViewModel as Stable

* Made IconsRow() paramaters stable

* Made SortModel()'s parameters stable

* Made PieChart()'s parameters stable

* Added composables to unstable composables baseline

screen/accounts/src/main/java/com/ivy/accounts/AccountsViewModel.kt

@@ -4,6 +4,7 @@ import android.annotation.SuppressLint
 import android.content.Context
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.data.db.dao.write.WriteAccountDao
@@ -30,6 +31,7 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @SuppressLint("StaticFieldLeak")
 @HiltViewModel
 class AccountsViewModel @Inject constructor(

screen/attributions/src/main/java/com/ivy/attributions/AttributionsViewModel.kt

@@ -1,10 +1,12 @@
 package com.ivy.attributions
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import com.ivy.domain.ComposeViewModel
 import dagger.hilt.android.lifecycle.HiltViewModel
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class AttributionsViewModel @Inject constructor(
     private val attributionsProvider: AttributionsProvider

screen/balance/src/main/java/com/ivy/balance/BalanceViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.balance
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableIntStateOf
 import androidx.compose.runtime.mutableStateOf
@@ -16,6 +17,7 @@ import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class BalanceViewModel @Inject constructor(
     private val plannedPaymentsLogic: PlannedPaymentsLogic,

screen/budgets/src/main/java/com/ivy/budgets/BudgetViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.budgets
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -35,6 +36,7 @@ import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class BudgetViewModel @Inject constructor(
     private val sharedPrefs: SharedPrefs,

screen/categories/src/main/java/com/ivy/categories/CategoriesScreen.kt

@@ -69,6 +69,7 @@ import com.ivy.wallet.ui.theme.modal.edit.CategoryModal
 import com.ivy.wallet.ui.theme.modal.edit.CategoryModalData
 import com.ivy.wallet.ui.theme.toComposeColor
 import com.ivy.wallet.ui.theme.wallet.AmountCurrencyB1
+import kotlinx.collections.immutable.ImmutableList
 import kotlinx.collections.immutable.persistentListOf
 import java.util.UUID
 
@@ -415,7 +416,7 @@ private fun CategoryHeader(
 @Suppress("UnusedParameter")
 @Composable
 fun BoxWithConstraintsScope.SortModal(
-    items: List<SortOrder>,
+    items: ImmutableList<SortOrder>,
     visible: Boolean,
     initialType: SortOrder,
     dismiss: () -> Unit,

screen/categories/src/main/java/com/ivy/categories/CategoriesViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.categories
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.base.legacy.Transaction
@@ -31,6 +32,7 @@ import kotlinx.coroutines.awaitAll
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class CategoriesViewModel @Inject constructor(
     private val categoryCreator: CategoryCreator,

screen/contributors/src/main/java/com/ivy/contributors/ContributorsViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.contributors
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.domain.ComposeViewModel
@@ -10,6 +11,7 @@ import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class ContributorsViewModel @Inject constructor(
     private val ivyWalletRepositoryDataSource: IvyWalletRepositoryDataSource

screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt

@@ -1,6 +1,7 @@
 package com.ivy.transaction
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -58,6 +59,7 @@ import java.time.LocalTime
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class EditTransactionViewModel @Inject constructor(
     private val loanDao: LoanDao,

screen/exchange-rates/src/main/java/com/ivy/exchangerates/ExchangeRatesViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.exchangerates
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.data.db.dao.read.ExchangeRatesDao
@@ -22,6 +23,7 @@ import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class ExchangeRatesViewModel @Inject constructor(
     private val exchangeRatesDao: ExchangeRatesDao,

screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt

@@ -3,6 +3,7 @@ package com.ivy.features
 import android.annotation.SuppressLint
 import android.content.Context
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.lifecycle.viewModelScope
 import com.ivy.domain.ComposeViewModel
 import com.ivy.domain.features.Features
@@ -14,6 +15,7 @@ import kotlinx.coroutines.flow.first
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @SuppressLint("StaticFieldLeak")
 @HiltViewModel
 class FeaturesViewModel @Inject constructor(

screen/home/src/main/java/com/ivy/home/HomeViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.home
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.base.legacy.Theme
@@ -56,6 +57,7 @@ import kotlinx.coroutines.launch
 import java.math.BigDecimal
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class HomeViewModel @Inject constructor(
     private val ivyContext: IvyWalletCtx,

screen/loans/src/main/java/com/ivy/loans/loan/LoanViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.loans.loan
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.base.legacy.SharedPrefs
@@ -37,6 +38,7 @@ import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class LoanViewModel @Inject constructor(
     private val loanRecordDao: LoanRecordDao,

screen/loans/src/main/java/com/ivy/loans/loandetails/LoanDetailsViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.loans.loandetails
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -49,6 +50,7 @@ import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class LoanDetailsViewModel @Inject constructor(
     private val loanDao: LoanDao,

screen/onboarding/src/main/java/com/ivy/onboarding/viewmodel/OnboardingViewModel.kt

@@ -1,6 +1,7 @@
 package com.ivy.onboarding.viewmodel
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.State
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -43,6 +44,7 @@ import kotlinx.coroutines.launch
 import timber.log.Timber
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class OnboardingViewModel @Inject constructor(
     private val ivyContext: IvyWalletCtx,

screen/piechart/src/main/java/com/ivy/piechart/PieChart.kt

@@ -28,6 +28,8 @@ import com.ivy.legacy.utils.timeNowUTC
 import com.ivy.resources.R
 import com.ivy.wallet.ui.theme.*
 import com.ivy.wallet.ui.theme.components.IvyIcon
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
 import timber.log.Timber
 import kotlin.math.acos
 import kotlin.math.sqrt
@@ -38,7 +40,7 @@ const val RADIUS_DP = 112f
 @Composable
 fun PieChart(
     type: TransactionType,
-    categoryAmounts: List<CategoryAmount>,
+    categoryAmounts: ImmutableList<CategoryAmount>,
     selectedCategory: SelectedCategory?,
     modifier: Modifier = Modifier,
     onCategoryClicked: (Category?) -> Unit = {}
@@ -270,7 +272,7 @@ private fun Preview() {
 
             PieChart(
                 type = TransactionType.EXPENSE,
-                categoryAmounts = listOf(
+                categoryAmounts = persistentListOf(
                     CategoryAmount(
                         category = Category("Bills", Green.toArgb()),
                         amount = 791.0

screen/piechart/src/main/java/com/ivy/piechart/PieChartStatisticViewModel.kt

@@ -1,6 +1,7 @@
 package com.ivy.piechart
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -25,6 +26,7 @@ import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class PieChartStatisticViewModel @Inject constructor(
     private val settingsDao: SettingsDao,

screen/planned-payments/src/main/java/com/ivy/planned/edit/EditPlannedViewModel.kt

@@ -1,6 +1,7 @@
 package com.ivy.planned.edit
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -39,6 +40,7 @@ import kotlinx.coroutines.launch
 import java.time.LocalDateTime
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class EditPlannedViewModel @Inject constructor(
     private val accountDao: AccountDao,

screen/planned-payments/src/main/java/com/ivy/planned/list/PlannedPaymentsViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.planned.list
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -21,6 +22,7 @@ import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class PlannedPaymentsViewModel @Inject constructor(
     private val settingsDao: SettingsDao,

screen/releases/src/main/java/com/ivy/releases/ReleasesViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.releases
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.domain.ComposeViewModel
@@ -10,6 +11,7 @@ import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class ReleasesViewModel @Inject constructor(
     private val releasesDataSource: ReleasesDataSource,

screen/reports/src/main/java/com/ivy/reports/ReportViewModel.kt

@@ -3,6 +3,7 @@ package com.ivy.reports
 import android.content.Context
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.ui.graphics.toArgb
@@ -49,6 +50,7 @@ import java.math.BigDecimal
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class ReportViewModel @Inject constructor(
     private val plannedPaymentsLogic: PlannedPaymentsLogic,

screen/search/src/main/java/com/ivy/search/SearchViewModel.kt

@@ -2,6 +2,7 @@ package com.ivy.search
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
 import com.ivy.base.legacy.TransactionHistoryItem
@@ -22,6 +23,7 @@ import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class SearchViewModel @Inject constructor(
     private val trnsWithDateDivsAct: TrnsWithDateDivsAct,

screen/settings/src/main/java/com/ivy/settings/SettingsViewModel.kt

@@ -4,6 +4,7 @@ import android.annotation.SuppressLint
 import android.content.Context
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableIntStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.lifecycle.viewModelScope
@@ -35,6 +36,7 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import javax.inject.Inject
 
+@Stable
 @SuppressLint("StaticFieldLeak")
 @HiltViewModel
 class SettingsViewModel @Inject constructor(

screen/transactions/src/main/java/com/ivy/transactions/TransactionsViewModel.kt

@@ -1,6 +1,7 @@
 package com.ivy.transactions
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.ui.graphics.toArgb
@@ -59,6 +60,7 @@ import kotlinx.coroutines.launch
 import java.util.UUID
 import javax.inject.Inject
 
+@Stable
 @HiltViewModel
 class TransactionsViewModel @Inject constructor(
     private val accountDao: AccountDao,

shared/domain/src/main/java/com/ivy/domain/ComposeViewModel.kt

@@ -1,11 +1,13 @@
 package com.ivy.domain
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.lifecycle.ViewModel
 
 /**
  * A simple base ViewModel utilizing Compose' reactivity.
  */
+@Stable
 abstract class ComposeViewModel<UiState, UiEvent> : ViewModel() {
     /**
      * Optimized for Compose ui state.