Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_t1utils.sh #22

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Pierre-Gronau-ndaal
Copy link

Line 5:
if cat /etc/*release | grep ^NAME | egrep 'CentOS|Red|Fedora'; then
^-- SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.

Line 9:
elif cat /etc/*release | grep ^NAME | egrep 'Ubuntu|Debian|Mint|Knoppix'; then
^-- SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.

Line 13:
elif ! echo uname -a | grep Darwin 2>&1 >/dev/null; then
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks ....
^-- SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).

Did you mean: (apply this, apply all SC2006)
elif ! echo $(uname -a) | grep Darwin 2>&1 >/dev/null; then

Line 28:
source "$SCRIPT_PATH/lib/project_paths.sh"
^-- SC1091 (info): Not following: ./lib/project_paths.sh was not specified as input (see shellcheck -x).

Line 5:
if cat /etc/*release | grep ^NAME | egrep 'CentOS|Red|Fedora'; then
                                    ^-- SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.
 
Line 9:
elif cat /etc/*release | grep ^NAME | egrep 'Ubuntu|Debian|Mint|Knoppix'; then
                                      ^-- SC2196 (info): egrep is non-standard and deprecated. Use grep -E instead.
 
Line 13:
elif ! echo `uname -a` | grep Darwin 2>&1 >/dev/null; then
            ^-- SC2046 (warning): Quote this to prevent word splitting.
            ^-- SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
            ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                     ^-- SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).

Did you mean: (apply this, apply all SC2006)
elif ! echo $(uname -a) | grep Darwin 2>&1 >/dev/null; then
 
Line 28:
source "$SCRIPT_PATH/lib/project_paths.sh"
       ^-- SC1091 (info): Not following: ./lib/project_paths.sh was not specified as input (see shellcheck -x).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant