Update .changes history according to move operation
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michitux
reviewed
May 7, 2024
| $history_content = file_get_contents($new_path); | ||
|
|
||
| $old_pagename = str_replace("/", ":", substr($old_path, strlen($conf['metadir']) + 1, -8)); | ||
| $new_pagename = str_replace("/", ":", substr($new_path, strlen($conf['metadir']) + 1, -8)); |
There was a problem hiding this comment.
I think this is missing an utf8_decodeFN to remove the (potential) encoding of the filename. Also, what speaks against just using $src_ns, $dst_ns, $src_name and $dst_name in the calling method to construct both IDs without the complicated step of first constructing filenames?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pagename in history entries(contents of
.changesfile) are not edited according to move, users can't access to old history entry before moving.This PR resolves the problem, by updating pagename in
.changesfile.