Volume delta fix #1022
Open
Volume delta fix #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft at the present moment as there is garbage in this PR that I am going to use the github comparison view to clean out |
SteveMicroNova
force-pushed
the
VolumeDeltaFix
branch
from
120a075 to
577617f
Compare
SteveMicroNova
force-pushed
the
VolumeDeltaFix
branch
from
18468c9 to
f2a8230
Compare
linknum23
reviewed
Jan 28, 2025
linknum23
reviewed
Jan 28, 2025
linknum23
reviewed
Jan 28, 2025
SteveMicroNova
force-pushed
the
VolumeDeltaFix
branch
from
85b93ca to
5be3e81
Compare
linknum23
reviewed
Jan 29, 2025
Add api skip function to the frontend to help avoid race conditions Co-authored-by: Lincoln Lorenz <[email protected]>
SteveMicroNova
force-pushed
the
VolumeDeltaFix
branch
from
4ff16a6 to
91f2095
Compare
|
Add tests before moving on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Closes #1021
We had a system of figuring out the delta of every individual zone attached to a source and then forcing those through the source endpoints one by one, and that caused lag. This PR brings that behavior to the backend, handles it with the /zones endpoint so we can do this more effectively and keep the system from lagging due to having a large number of fetch requests if you move the volume bar up and down rapidly.
Checklist
./scripts/test