Add default streams for first startup #1023
Conversation
|
Wasn't the plan to also have 2 Spotify and 2 Airplay streams added out of the box. Additionally there would be one of each of those that was connected to a source but not connected to any zones. |
|
I have this debate as to whether it makes sense to start with some small volume instead of being completely muted. |
I feel that we've gone back and forth on this, so I did the smallest lift. I can happily go back to the airplay+spotify version of this intent
I'd argue completely muted, I don't want to be responsible for figuring out what is a good volume to have it audible on quiet speakers but not explode loud ones before they can dial in their DB gate settings. |
SteveMicroNova
force-pushed
the
DefaultSalad
branch
from
e049ad6 to
293f359
Compare
SteveMicroNova
changed the title
| {"id": 0, "name": "Input 1", "input": ""}, | ||
| {"id": 1, "name": "Input 2", "input": ""}, | ||
| {"id": 2, "name": "Input 3", "input": ""}, | ||
| {"id": 3, "name": "Input 4", "input": ""}, |
There was a problem hiding this comment.
I don't think that these being called inputs is used anywhere, but they are outputs so I made sure they were named that in line with the streamer section as well
Correct me if needed
|
We could potentially setup 3 sources in the cleanup script. One connecting groove salad to the first source with all 6 zones, with the 2 other sources connected to a spotify and an airplay stream respectively. |
SteveMicroNova
force-pushed
the
DefaultSalad
branch
from
29ed07a to
21db59f
Compare
|
I've updated the cleanup script and ran it against my dev unit, this is the result: |
|
Looks good. Any reason these streams shouldn't each be named AmpliPi 1 and AmpliPi 2? Or maybe AmpliPro 1 and AmpliPro 2? I would expect them to be called be the name of the device initially when trying to find them on Spotify or Airplay. Most people will have several spotify/airplay capable devices at home and this will make them easy to identify initially. |
We add 4 new streams in this PR: SpotiPi 1, SpotiPi 2, AmpliPlay 1, and AmpliPlay 2. The ones that connect by default are SpotiPi 1 (because that's the first one) and AmpliPlay 2 (because there is one that is Airplay 1 and one that is Airplay 2, and having those numbers not match up seemed bothersome) |
|
Yeah I get that. I guess I just have a preference for the Spotify Streams to be name |
|
Airplay streams show up in Spotify too on IOS right? If I'm remembering that correctly you should def not have any overlap. I actually don't mind the funny names but APSpotify/APAirplay would be more professional. |
No, Airplay does show up but you have to open it as a separate window so that should be safe |
|
Oh ok, call it Amplipro then? |
…rst startup Update cleanup script to connect default streams
SteveMicroNova
force-pushed
the
DefaultSalad
branch
from
3d8ac92 to
215f5c7
Compare
|
|
|
Jason has also said "AmpliPro 1 and 2 is fine for all of those" so that seems to be the way forward |
| {"id": 1001, "name": "AmpliPi 1", "type": "spotify", "disabled": False, "browsable": False}, | ||
| {"id": 1002, "name": "AmpliPi 2", "type": "spotify", "disabled": False, "browsable": False}, | ||
| {"id": 1003, "name": "AmpliPi 1", "type": "airplay", "disabled": False, "ap2": False, "browsable": False}, | ||
| {"id": 1004, "name": "AmpliPi 2", "type": "airplay", "disabled": False, "ap2": True, "browsable": False} |
There was a problem hiding this comment.
These should probably be called AmpliPro 1/2 as well right?
Sets system default state to Groove Salad connected to all zones at 0 volume and muted everywhere, as well as Spotify and Airplay2 sources connected to no zones for first startup
Can be tested by going to Setttings -> Config -> Factory Reset
Checklist
./scripts/test