Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthand button creation to ModalCard #1026

Open
wants to merge 1 commit into
base: PresetAndAddCreation
Choose a base branch
from

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Feb 6, 2025

What does this change intend to accomplish?

This is a sister PR to #1015 and so will be merged into #1015 if this merges first, and into main if this merges second

This is not directly a part of #1015 because the amount of replumbing that this entailed seemed like any issues this causes would easily become a needle in a haystack

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If applicable, have you updated the CHANGELOG?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

@SteveMicroNova
Copy link
Contributor Author

Only asking Klayton to review this time as he has opinions on how to React
I think that my solution is potentially gross, but is good for dynamically creating any number of buttons without needing to import new components on every page that uses the ModalCard

@SteveMicroNova
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant