Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin from PageHeader #1027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SteveMicroNova
Copy link
Contributor

What does this change intend to accomplish?

I noticed there was a thin black strip at the top of the screen on the About page, and found it was due to the PageHeader component having a 0.5 rem margin-top

This PR fixes that

Before:
image

After:
image

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.81%. Comparing base (7499989) to head (9fd12ae).
Report is 64 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   50.67%   49.81%   -0.86%     
==========================================
  Files          40       41       +1     
  Lines        7154     7303     +149     
==========================================
+ Hits         3625     3638      +13     
- Misses       3529     3665     +136     
Flag Coverage Δ
unittests 49.81% <ø> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveMicroNova SteveMicroNova changed the title Remove margin-top from PageHeader Remove margin from PageHeader Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants