New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preamp v4 Support #551

Merged

Lohrer merged 53 commits into develop from preamp_v4

Dec 8, 2023

Collaborator

Lohrer commented Dec 5, 2023 •

edited

Loading

TODO:

Verify production tests pass.
Update changelog with v1.7 changes.
Finish Preamp EEPROM register documentation.

Lohrer added the firmware label

Lohrer self-assigned this

codecov-commenter commented Dec 5, 2023 •

edited

Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6799b8e) 51.52% compared to head (623a40c) 51.53%.
Report is 1 commits behind head on develop.

Files	Patch %	Lines
amplipi/hw.py	0.00%	15 Missing ⚠️
amplipi/rt.py	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    51.52%   51.53%           
========================================
  Files           24       24           
  Lines         5673     5676    +3     
========================================
+ Hits          2923     2925    +2     
- Misses        2750     2751    +1

Flag	Coverage Δ
unittests	`51.53% <10.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lohrer force-pushed the preamp_v4 branch 2 times, most recently from bdbf21a to 314d2b0 Compare

December 5, 2023 22:41

Lohrer marked this pull request as ready for review

December 7, 2023 21:02

linknum23 self-requested a review

December 7, 2023 21:43

linknum23 reviewed

View reviewed changes

amplipi/hw.py Outdated Show resolved Hide resolved

linknum23 reviewed

View reviewed changes

fw/preamp/CMakeLists.txt Outdated Show resolved Hide resolved

linknum23 reviewed

View reviewed changes

fw/preamp/preamp.ld Show resolved Hide resolved

linknum23 reviewed

View reviewed changes

fw/preamp/src/audio.c Show resolved Hide resolved

linknum23 reviewed

View reviewed changes

fw/preamp/src/ctrl_i2c.c Show resolved Hide resolved

linknum23 reviewed

View reviewed changes

fw/preamp/src/i2c.c Show resolved Hide resolved

linknum23 approved these changes

View reviewed changes

Contributor

linknum23 left a comment

Rubber Stamp - There are too many changes to review here

Contributor

linknum23 commented Dec 7, 2023

Lets do some good real world testing on this

Lohrer force-pushed the preamp_v4 branch 2 times, most recently from 9cd55cc to 5e2d875 Compare

December 8, 2023 19:30

gorski123 and others added 13 commits

December 8, 2023 14:34


          Setting src enable pins to open drain


          Revert analog mux pins from open drain back to push pull

15af3ee


          Fixed firmware version range check not including edge values

295f5a2


          Updated hardware schematics and release info

f65e3fa


          Removed old STM32 workbench files

98325ba


          Better firmware size printout

d0eadc1


          Update copyright year to 2023


          Auto-format firmware source files

8741b01


          Change header guards to #pragma once

2ef9d5b


          Removed unused STM32F0xx stdperiph library components

1d558cb


          Updated stm32f0xx.h to v1.5.2

b40c2f2


          Swap analog mux control pin polarities for testing

25f9daa


          Allow CMakeLists to use whichever python is active

18fb8cb

Lohrer added 22 commits

December 8, 2023 14:34


          Cleaned up startup_stm32.s

fbc3595


          Added WWDG watchdog timer

8f995bb

Set NRST_OUT to open-drain with pullup for proper expander reset. Main unit will have to wait for a hardware update...


          Update compiler install documentation

0dcd741


          Use -std=c2x

d58268c


          Updated linker script

797f974


          Added debug printouts

b860e79


          Removed HW_VERSION multiple builds

44fd753


          Check for EEPROM then set audio muxes accordingly

45d81f4


          I2C cleanup

238e4ad


          Update i2c timing docs and start EEPROM python support

c98ee7b


          Robustified address reception over serial

14e063b


          WIP EEPROM read/write

2a8990d


          More EEPROM WIP

ed183d8


          Updated firmware github workflow

88e5075


          Add EEPROM I2C requests from Pi and update I2C read function

71a4619


          Updated readme to note libncursesw5 isn't really required.

423282c


          Fixed read/write command

48a5632


          Don't force EEPROM reads on old boards

948eb90


          Add rev4 bit to firmware version registers

4d667f6


          Documented EEPROM interface


          Added option to disable debug prints

f21529e


          Set NRST_OUT to push-pull for now to fix boot resets

50f71ba

This means watchdog resets won't work.

Lohrer force-pushed the preamp_v4 branch from 5e2d875 to 623a40c Compare

December 8, 2023 19:35

Lohrer added 2 commits

December 8, 2023 14:46


          Force attempting to write unit 1

d75b817


          Added a debug message when an I2C read or write is requested

4e24746

Lohrer force-pushed the preamp_v4 branch from 623a40c to 41da31b Compare

December 8, 2023 19:48


          Added preamp v1.7 binary, removed old binaries, and updated changelog

63dde4e

Lohrer force-pushed the preamp_v4 branch from 41da31b to 63dde4e Compare

December 8, 2023 20:42

Lohrer merged commit dd618f0 into develop

3 checks passed

Lohrer deleted the preamp_v4 branch

December 11, 2023 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels