Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preamp v1.7 reported version number fix #560

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Preamp v1.7 reported version number fix #560

merged 2 commits into from
Dec 11, 2023

Conversation

Lohrer
Copy link
Collaborator

@Lohrer Lohrer commented Dec 11, 2023

Got the hash right but somehow it was still reporting v1.6, no idea how that happened or how I missed it... Now all is good! I also fixed a debug printout in the programming script.

@Lohrer Lohrer requested a review from rtertiaer December 11, 2023 15:14
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6799b8e) 51.52% compared to head (de30cd2) 51.53%.
Report is 55 commits behind head on develop.

Files Patch % Lines
amplipi/hw.py 0.00% 15 Missing ⚠️
amplipi/rt.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #560   +/-   ##
========================================
  Coverage    51.52%   51.53%           
========================================
  Files           24       24           
  Lines         5673     5676    +3     
========================================
+ Hits          2923     2925    +2     
- Misses        2750     2751    +1     
Flag Coverage Δ
unittests 51.53% <10.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lohrer Lohrer merged commit 51b3da4 into develop Dec 11, 2023
3 checks passed
@Lohrer Lohrer deleted the preamp_v1.7_fix branch December 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants