Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression introduced in Spotify bugfix #566

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix regression introduced in Spotify bugfix #566

merged 1 commit into from
Dec 12, 2023

Conversation

rtertiaer
Copy link
Contributor

This PR fixes a bug introduced during #565 ; we don't use the outputs of communicate, and kill doesn't even output. The tests failed on this; it's not clear why Github let me merge anyhow, when our branch protections require passing tests for everybody, including administrators 🥴

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ca1da8) 51.53% compared to head (ce0dd7f) 51.60%.
Report is 1 commits behind head on develop.

Files Patch % Lines
amplipi/streams.py 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #566      +/-   ##
===========================================
+ Coverage    51.53%   51.60%   +0.07%     
===========================================
  Files           24       24              
  Lines         5676     5676              
===========================================
+ Hits          2925     2929       +4     
+ Misses        2751     2747       -4     
Flag Coverage Δ
unittests 51.60% <60.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs further explanation. Why was it failing?

@linknum23
Copy link
Contributor

TLDR: It worked fine but the linter caught some unused and non-existent return values which were reported as errors.

@rtertiaer
Copy link
Contributor Author

this is deployed & waiting on others to test on the appliance in-house; then stamping out 0.3.0 🎊

@rtertiaer rtertiaer merged commit ce0dd7f into develop Dec 12, 2023
3 checks passed
@rtertiaer rtertiaer deleted the fix_tests branch December 12, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants