Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show disabled streams in selection modal #593

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

rtertiaer
Copy link
Contributor

@rtertiaer rtertiaer commented Jan 2, 2024

What does this change intend to accomplish?

Disabled streams no longer show up in the selection dialog. This PR fixes #574

Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If applicable, have you updated the CHANGELOG?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test

@rtertiaer rtertiaer requested a review from linknum23 January 2, 2024 19:18
@codecov-commenter
Copy link

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (132a762) 51.60% compared to head (ec512ea) 51.50%.
Report is 12 commits behind head on main.

Files Patch % Lines
amplipi/streams.py 26.31% 42 Missing ⚠️
amplipi/rt.py 24.00% 38 Missing ⚠️
amplipi/display/epd2in13_V3.py 0.00% 27 Missing ⚠️
amplipi/app.py 62.96% 10 Missing ⚠️
amplipi/ctrl.py 85.36% 6 Missing ⚠️
amplipi/display/einkdisplay.py 0.00% 6 Missing ⚠️
amplipi/hw.py 84.37% 5 Missing ⚠️
amplipi/updater/asgi.py 0.00% 5 Missing ⚠️
amplipi/eeprom.py 33.33% 4 Missing ⚠️
amplipi/extras.py 0.00% 4 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   51.60%   51.50%   -0.10%     
==========================================
  Files          24       24              
  Lines        5676     5677       +1     
==========================================
- Hits         2929     2924       -5     
- Misses       2747     2753       +6     
Flag Coverage Δ
unittests 51.50% <47.29%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we may want to indicate that streams are disabled in settings->streams. For now this works great, both RCA inputs and normal streams respect the disabled flag.

@rtertiaer rtertiaer merged commit ec512ea into main Jan 2, 2024
3 checks passed
@rtertiaer rtertiaer deleted the no_disabled_streams_in_ui branch January 2, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - RCA Inputs and other streams are still shown in UI when disabled
3 participants