Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for altexp functionality #16

Open
wants to merge 54 commits into
base: devel
Choose a base branch
from

Conversation

ArioMoniri
Copy link

πŸ§ͺ Multiple Experimental Assay Analysis Tool

πŸš€ Updates & Additions

βœ… UI Enhancements:

  • Added new components to the User Interface (UI).
  • Some UI elements might be unnecessary and could be removed.

βœ… Core Functionality:

  • Updated Main Function with improvements.
  • Made changes to Utils to support additional features.

βœ… CI/CD Improvements:

  • Integrated CI/CD pipeline updates.

⚠️ Issues & Solutions

πŸ”— Issue: Microbiome Analysis Dashboard Header Redirection

  • The header of Microbiome Analysis Dashboard - v0.99.7 redirected to the main page, but did not refresh the page.

βœ… Solution:

  • Added a force refresh to the onClick redirection in the miaDash file.

πŸ” Effect:

  • Ensures that the page reloads properly when clicking on the header.

πŸ› οΈ Issue: Large Dataset Handling

  • The package struggles with handling large datasets, but no edits were made for this yet.

🚨 Next Steps:

  • Investigate and implement data size checker and custom default panels list for large datasets.

πŸ“‰ Visualization & UI Concerns

❗ Alternative Expression (Alt Exp) Plot Visualization

  • Issue: Haven't been able to fully test Alt Exp visualization because no dummy data is available in a merged RDS format.
  • Need to validate:
    • πŸ“Š Plot visualization logic
    • πŸ“‚ Dropdown menu functionality for selecting agglomeration or visualization method

πŸ’‘ Solution Needed:

  • Dummy Data Required πŸ“πŸ”¬ (Merged .rds format for proper testing).

πŸ”§ Next Steps

πŸ” Review & Cleanup:

  • Identify and remove unnecessary UI elements.

πŸ›  Debugging & Testing:

  • Validate plot visualization & dropdown selection.
  • Create & test with dummy merged .rds data.

⚑ Optimize Large Dataset Handling:

  • Address the package issue affecting large dataset performance.

Image_20250218_150629

@ArioMoniri
Copy link
Author

let see ( in some parts it didnt pass the codeFactor but they are not sth effecting the plot generation

Copy link
Member

@RiboRings RiboRings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the additions and fixes. Let's begin with the altExp functionality.

We don't expect the users to import altExp by themselves. It is more likely that they want to create altExps when subsetting or agglomerating the TreeSE without replacing the original experiment. So we could:

  • Remove Alternative Experiment tab in Import box
  • Add a new tab called for instance "Switch" to the Manipulate box, which allows users to switch from an experiment to another for all the future operations. I think there is a slot in TreeSE objects called mainExpName that might be useful for this.
  • Remove "Apply to" from the Manipulate box
  • Add a checkbox to Subset and Agglomerate tabs so users can select if they want to replace the current TreeSE or store the new object as an altExp, and if so under which name. These two elements (checkbox and text box for naming) can be shared by the two tabs), check how it's done for example in alpha and beta diversity naming box.

For the new parameters in the Visualise box, I think they are doing the same as the Panels list below(?)

Thanks again! I'll check the rest after we get through these initial changes. I'm open for further discussion if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants