Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reference samples to divergence outputs #100

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

add reference samples to divergence outputs #100

wants to merge 2 commits into from

Conversation

Daenarys8
Copy link
Contributor

TuomasBorman
TuomasBorman requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the code? It seems not to work. Instead of adding reference samples to df, it adds the name of reference sample column. Instead, the reference samples are stored in x[[reference]].

R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
tests/testthat/test-getStepwiseDivergence.R Outdated Show resolved Hide resolved
vignettes/miaTime.Rmd Outdated Show resolved Hide resolved
vignettes/articles/minimalgut.Rmd Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
@Daenarys8
add changes to refsam
0d1373b 
Signed-off-by: Daena Rys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuomasBorman TuomasBorman TuomasBorman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daenarys8 @TuomasBorman