Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignettes #97

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

vignettes #97

wants to merge 9 commits into from

Conversation

Daenarys8
Copy link
Contributor

ping #96

Signed-off-by: Daena Rys <[email protected]>
vignettes/articles/minimalgut.Rmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Leo's comment. Also can you check if it is easy to get quarto vignettes working?

Currently the style is quarto but the files are Rmd. I noticed previously that there were no support for quarto vignettes yet as it requires quarto vignette vignette builder instead of knitr, but I don't know what is the stage now. If there is no official support let's keep everything like this and wait

Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Contributor Author

the engine is now supported in quarto v1.4

Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Contributor Author

This is good but we have obstacle since rworkflows does not support quarto

Signed-off-by: Daena Rys <[email protected]>
@TuomasBorman
Copy link
Collaborator

We can

  1. Keep the old engine and files as Rmd. Keep the quarto style so we can easily switch from Rmd to quarto when the engine is supported
  2. Create an issue to rworkflows and ask about this

Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Contributor Author

Any idea why there's no mac runner in bioc 3.21? it is affecting mac os builds on gha.
@TuomasBorman

@TuomasBorman
Copy link
Collaborator

I believe they are updating them currently, there is some delay

Copy link
Collaborator

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, otherwise looks nice

vignettes/articles/manipulation.Rmd Outdated Show resolved Hide resolved
vignettes/articles/minimalgut.Rmd Show resolved Hide resolved
Signed-off-by: Daena Rys <[email protected]>
Copy link
Collaborator

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

vignettes/articles/minimalgut.Rmd Outdated Show resolved Hide resolved
vignettes/articles/manipulation.Rmd Outdated Show resolved Hide resolved
vignettes/articles/minimalgut.Rmd Outdated Show resolved Hide resolved
vignettes/articles/manipulation.Rmd Outdated Show resolved Hide resolved
Signed-off-by: Daena Rys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants