Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace getPrevalent* and getTop* functions #118

Merged
merged 6 commits into from
Jun 28, 2024
Merged

replace getPrevalent* and getTop* functions #118

merged 6 commits into from
Jun 28, 2024

Conversation

thpralas
Copy link
Contributor

After mia PR microbiome/mia#526 that renamed the following functions :

  • getRareFeatures --> getRare

  • getRareTaxa --> getRare

  • getTopFeatures --> getTop

  • getTopTaxa --> getTop

  • getPrevalentFeatures --> getPrevalent

  • getPrevalentTaxa --> getPrevalent

  • getUniqueFeatures --> getUnique

  • getUniqueTaxa --> getUnique

This PR replaces the getTop* and getPrevalent* functions used in miaViz.

@antagomir
Copy link
Member

antagomir commented May 21, 2024 •
edited
Loading

Conflicts to resolve.. seems otherwise good to me.

@antagomir
Copy link
Member

up

@TuomasBorman
up
9f2c8d4 
Sync

# Conflicts:
#	R/plotTree.R
#	man/plotTree.Rd
@TuomasBorman
up
305df64
@TuomasBorman TuomasBorman merged commit b805f81 into devel Jun 28, 2024
1 of 3 checks passed
@TuomasBorman TuomasBorman deleted the rename_getters branch June 28, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuomasBorman TuomasBorman TuomasBorman approved these changes

@antagomir antagomir antagomir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thpralas @antagomir @TuomasBorman