Adding confidence level as a parameter #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antagomir
reviewed
May 21, 2024
R/plotCCA.R
Outdated
Comment on lines
28
to
29
| #' @param ellipse.level Number between 0 and 1 to adjust confidence level. | ||
| #' (default: \code{ellipse.level = 0.95}) |
There was a problem hiding this comment.
wouldn't a more descriptive name be "confidence.level"?
|
status of this? |
|
Fixed what had to be, however build still fails in ubuntu and no idea how to solve (gave it a few try already) |
|
This should be work when psuhed to devel |
|
Also bump the version |
|
Also update NEWS file "Added confidence.interval parameter to plotCCA" or something |
TuomasBorman
approved these changes
May 27, 2024
|
Should be fine now |
added 2 commits
May 27, 2024 17:18
TuomasBorman
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #110