-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for groups other than rank in plotAbundance #148
Conversation
Signed-off-by: Daena Rys <[email protected]>
Thanks, seems to work! However, I think we should think if this is needed as this makes the function more complex. The same can be achieved as follows which might be more transparent (I prefer that)
Second thing is that, Instead of changing the name, one option is to "hiddenly" support other grouping variables. The name could be |
This naming is related to issue/PR that is open in mia. Wait until we have fixed that. |
Signed-off-by: Daena Rys <[email protected]>
We decided to prefer that user does (relative) transformation outside the function. That is why as.relative was moved to "hidden" parameter. This means that also agglomeration should be done outside the function. --> I moved rank/group parameter as hidden parameter. |
This commit deprecates rank and adds support for other columns in rowData
ping: #100