Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadlock mitigation redux #79

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

jessepeterson
Copy link
Member

@jessepeterson jessepeterson commented Dec 11, 2024

While I thought we addressed this in #75 it was not. There are two delete operations: one for the commands and one for the step. I believe we mitigated the command deletion deadlock with #75 but the step deletion deadlock remained. To help with this we:

  • rolled the row locks into the step id command retrieval query vs. a separate lock query.
    • also using joins to extend the lock, even though we aren't using that joined info
  • narrowed the step deletion to just be related to the relevant command step, rather than all steps which should already be locked due to the above.

Hopefully this gets us where we need to be. Both Go unit tests and mdmb tests were done to verify operation.

@jessepeterson jessepeterson merged commit f7e0736 into micromdm:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant