-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure HTTP Functions compliant with TCK #509
Conversation
Right, this doesn't work as starter generates code such as:
This was broken by #398 |
Tried it in real azure Returns no content 😭 |
So I think it's an issue with getNativeResponse 🤔 |
Raised micronaut-projects/micronaut-starter#1890 to deal with starter generating test code that doesn't work with 4.0.0 |
.../java/io/micronaut/azure/function/http/MapListOfStringAndMapStringConvertibleMultiValue.java
Outdated
Show resolved
Hide resolved
test-suite-azure-function-http-context-path/src/test/resources/logback.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a real nice piece of work. Congrats on clearing all the TCK tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to document you can bind:
com.microsoft.azure.functions.ExecutionContext
com.microsoft.azure.functions.HttpRequestMessage
com.microsoft.azure.functions.TraceContext
...function-http/src/main/java/io/micronaut/azure/function/http/HttpResponseMessageAdapter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It misses documentation about change.
* | ||
*/ | ||
@Internal | ||
public final class AzureCookies implements Cookies { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this class to io.micronaut.netty.cookies
in core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timyates create an issue for this and add it to 5.1.0 Release
project.
...function-http/src/main/java/io/micronaut/azure/function/http/BinaryContentConfiguration.java
Show resolved
Hide resolved
@graemerocher can you review this PR? It currently passes every TCK test and I have changed it to tell users they have to remove the azure api route prefix and then they can use normally |
I have created an issue for this. |
* Add TCK tests for http-test * Add snakeyml -- down to 4 failures * Fix parameters... 2 to go * Fixed reader... All fixed * Remove unused import
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This PR switches the Azure function handlers to use servlet-core in much the same way as the AWS module does.
Spotted working on this that in a previous PR #398 we broke the test code that we generate in Micronaut Starter (see #509 (comment))
I changed the tests in this module here https://github.com/micronaut-projects/micronaut-azure/pull/509/files#diff-5477701f4559e28df2025cfa073a4ca34eb84685ed452c0567f5c677f040a602
But I am not sure if it's correct...
I have tested this running a test project on Azure, and I think it's right, but it could do with someone who is used to using Azure to check we haven't broken anything important here
I also pulled in the context-path fix from #493 so we don't miss it (or someone else doesn't have to struggle with the merging)
Looking into
DefaultExecutionContext
to see why using it fails tests in third party apps