Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test resources client on optimizer classpath #853

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

melix
Copy link
Collaborator

@melix melix commented Oct 20, 2023

The AOT process should optimize applications for the production environment. As such it doesn't make sense to have the test resources client on the classpath of the application being scanned during the AOT optimization process.

This bugfix has the potential to break builds of people who run ./gradlew build and had builds passing because the AOT optimizer was using test resources.

Fixes #852

The AOT process should optimize applications for the production environment.
As such it doesn't make sense to have the test resources client on the
classpath of the application being scanned during the AOT optimization
process.

This bugfix has the potential to break builds of people who run
`./gradlew build` and had builds passing because the AOT optimizer was
using test resources.

Fixes #852
@melix melix added this to the 4.1.2 milestone Oct 20, 2023
@melix melix requested a review from graemerocher October 20, 2023 14:32
@melix melix self-assigned this Oct 20, 2023
@melix
Copy link
Collaborator Author

melix commented Oct 20, 2023

@graemerocher can you check that the fix works for you? You can checkout the branch and include it in your build by updating the settings.gradle file:

pluginManagement {
    includeBuild("/path/to/micronaut-gradle-plugin")
}

rootProject.name="..."

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@melix melix merged commit 339023b into master Oct 20, 2023
7 checks passed
@melix melix deleted the cc/issue-852 branch October 20, 2023 16:26
@runenielsen
Copy link

Thanks, @melix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Micronaut AOT does not work with Test Resources
3 participants