Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[283] Add new RestClientBuilder method for adding headers. #378

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

WhiteCat22
Copy link
Contributor

@WhiteCat22 WhiteCat22 commented Jun 11, 2024

Add a new RestClientBuilder.header(String, Object) method to add headers.

#fixes #283

@WhiteCat22 WhiteCat22 changed the title [283] Add new building methods for adding headers. [283] Add new building method for adding headers. Jun 11, 2024
@WhiteCat22 WhiteCat22 force-pushed the header_builder_method branch from 2d92023 to 2d1b125 Compare June 11, 2024 22:37
@WhiteCat22 WhiteCat22 changed the title [283] Add new building method for adding headers. [283] Add new RestClientBuilder method for adding headers. Jun 11, 2024
@WhiteCat22
Copy link
Contributor Author

The framework for ClientBuilderHeaderTest was copied from ClientHeaderParamTest

@WhiteCat22 WhiteCat22 force-pushed the header_builder_method branch 4 times, most recently from 32d1323 to b33c91a Compare June 14, 2024 21:12
@WhiteCat22 WhiteCat22 force-pushed the header_builder_method branch from b33c91a to 1471934 Compare June 14, 2024 21:18
… ClientHeaderParam annotations as they can only be defined on either the method or the interface, but not both.

Signed-off-by: James R. Perkins <[email protected]>
.addClasses(
ClientBuilderHeaderMethodClient.class,
ReturnWithAllDuplicateClientHeadersFilter.class,
WiremockArquillianTest.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should block the PR based on this, but we don't actually need the WiremockArquillianTest.class here.

@Emily-Jiang Emily-Jiang merged commit a223aec into microprofile:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: build method to pass request header in the RestClientBuilder
3 participants