Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import STM32Cube_FW_H7_V1.2.0 on 29-Dec-2017 #1

Closed
wants to merge 2 commits into from
Closed

Import STM32Cube_FW_H7_V1.2.0 on 29-Dec-2017 #1

wants to merge 2 commits into from

Conversation

iabdalkader
Copy link
Contributor

No description provided.

@dpgeorge
Copy link
Member

Thanks, it looks pretty good!

A couple of minor points:

  1. It looks like you changed tab to space and removed non-ASCII chars, but there are a few remaining (eg line 498 of STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_fdcan.h). That's probably because the clean_code() function provided in the README.md didn't cover this particular non-ASCII code. Right? I can fix this when merging.

  2. The date in the commit message should be the date of release of the HAL by ST, not the date it's committed here. It looks like the date of release by ST is 29 Dec 2017?

@iabdalkader
Copy link
Contributor Author

iabdalkader commented Feb 18, 2018

Hi, yes I ran the clean_code() function in a loop on all files, didn't double check the output. Note you should add -f to rm tmp because the files are read only by default. Can you fix the clean_code function? I'll run it again and commit with the proper date (29-December-2017).

EDIT: add -f to mv tmp$$ so mv -f tmp$$

@dpgeorge
Copy link
Member

Can you fix the clean_code function?

Ok, now fixed by 6df2b09 to process more non-ASCII chars. I also added a chmod 644 instead of mv -f.

@iabdalkader iabdalkader changed the title Import STM32Cube_FW_H7_V1.2.0 on 17-Feb-2018 Import STM32Cube_FW_H7_V1.2.0 on 29-Dec-2017 Feb 18, 2018
@iabdalkader
Copy link
Contributor Author

@dpgeorge Is this okay or should I redo the PR ?

@dpgeorge
Copy link
Member

Ok, thanks for updating, now merged in acaf64e. I also applied a new tag: F4-1.16.0+F7-1.7.0+H7-1.2.0+L4-1.8.1

@dpgeorge dpgeorge closed this Feb 19, 2018
@iabdalkader iabdalkader deleted the stm32h7 branch February 19, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants