Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data store connection status #2842

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dimitri-furman
Copy link
Contributor

Summary

  • Add text in the Data store group to provide data store connection status and informational messages to explain why connection to the data store isn't attempted.
  • Revert a previous change and move the "data store inaccessible" message back into the Data store group, to avoid showing it incorrectly while the connection is still being opened.
     

Screenshots

image
image
image

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@dimitri-furman dimitri-furman requested a review from a team as a code owner November 22, 2024 23:07
@dimitri-furman dimitri-furman merged commit 3daeb8e into master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants