Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Application-Insights-Workbooks #2890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bashirsaba
Copy link

@Bashirsaba Bashirsaba commented Feb 4, 2025

Application-Insights-Workbooks

Summary

Explain your changes, so people looking at the PR know what and why, the code changes are the how.

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).

    It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

Application-Insights-Workbooks
@Bashirsaba Bashirsaba requested a review from a team as a code owner February 4, 2025 10:31
@Bashirsaba
Copy link
Author

gh pr checkout 2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant