fix for empty loops and memory handling, handling of generated files #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerkle
commented
Oct 22, 2024
bmerkle
commented
- add generated files to .gitignore
- removed empty loops and commented out for for memory handling
- added call to free to avoid memory leak
- removed empty loops and commented out for for memory handling - added call to free to avoid memory leak
Gabrielfernandes7
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
@Gabrielfernandes7 Can you merge this into main ?
There was a problem hiding this comment.
unfortunatelly, i cannot, but i would like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.