Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering erroneous Adaptive Card #4852

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix rendering erroneous Adaptive Card #4852

merged 2 commits into from
Sep 21, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 7, 2023

Fixes #4849.

Changelog Entry

Fixed

  • Fixes #4849. Rendering an erroneous Adaptive Cards should bail out and not throw MutationObserver error, by @compulim, in PR #4852

Description

When failed to render Adaptive Cards, it should bail out, instead of throwing MutationObserver.observe error.

Specific Changes

  • Updated AdaptiveCardRenderer.tsx not to apply mods when failed to render Adaptive Cards to HTML
    • Also console.warn the error
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim
Copy link
Contributor Author

compulim commented Sep 8, 2023

The test errors are due to we added new commands for #4846, so the scrollbar changed a bit.

As we will merge this after #4846, we can pause and not fixing the test error for now.

@compulim compulim merged commit 960e671 into main Sep 21, 2023
10 checks passed
@compulim compulim deleted the fix-4849-ac-error branch September 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation Observer Error on Web Chat with DirectLine
2 participants