Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Redux store type #4877

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Revert Redux store type #4877

merged 2 commits into from
Sep 27, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 26, 2023

Fixes #4878.

Changelog Entry

Fixed

Description

We did not bump redux, it is still 4.2.1. So the signature from 4.15.9 should continue to work.

Design

4.15.9

import { type Store } from 'redux'

export type WebChatStore = Store;

4.15.10-0

import { createStore } from 'redux'

export type WebChatStore = ReturnType<typeof createStore>;

Specific Changes

  • Modify createStore.tsx to export type Store from redux, instead of ReturnType<typeof createStore>
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review September 26, 2023 22:08
@compulim compulim enabled auto-merge (squash) September 27, 2023 17:57
@compulim compulim merged commit 58ec6cd into main Sep 27, 2023
@compulim compulim deleted the fix-redux-type branch September 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createStore should return Store<any> than Store<unknown>
2 participants