-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base package #5176
Merged
Merged
Add base package #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 8, 2024 18:57
compulim
reviewed
May 8, 2024
compulim
reviewed
May 8, 2024
Let's make this For a cleaner approach, we should use |
Co-authored-by: William Wong <[email protected]>
OEvgeny
force-pushed
the
feature/base-package
branch
from
September 27, 2024 21:30
91037fc
to
a782437
Compare
compulim
reviewed
Oct 2, 2024
compulim
reviewed
Oct 2, 2024
compulim
reviewed
Oct 2, 2024
compulim
previously approved these changes
Oct 2, 2024
OEvgeny
commented
Oct 2, 2024
compulim
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
(No changelog entry for the internal change)
Description
This PR introduces a new private
botframework-webchat-base
package to centralize shared utilities and types across the Web Chat project. It also updates the build process for all packages to usetsup
, as otherwise the reference to the package is included into depending packages by babel.Design
The new base package serves as a foundation for shared functionality, promoting code reuse and maintainability. The build process changes aim to simplify and standardize the compilation across all packages, reducing complexity and potential inconsistencies.
Limitations
Due to how babel build works, only the packages which are using the new build approach powered by
tsup
can consume the base and styles packages. This limitation applies only to the packages we're publishing.Package Status List
Legend
tsup
introduced in this PRtsup
in this PRtsup
to use the base packageSpecific Changes
packages/base
directory with initial setupwithResolvers
utility fromcore
tobase
packagepackage.json
files across multiple packages:botframework-webchat-base
as a development dependencytsup
tsconfig.json
files to remove emission-related options-
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed