Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: improve dropzone #5328

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fluent: improve dropzone #5328

merged 2 commits into from
Oct 18, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Oct 17, 2024

Changelog Entry

  • Improved drop zone behavior and styling in Fluent theme, in PR #5328, by @OEvgeny

Description

This PR enhances the drop zone UX in the Fluent theme. The changes address issues with multiple drop zones and refine the styling to align better with Fluent design principles.

Specific Changes

  1. Fixed an issue where multiple drop zones could remain visible after a drop operation
  2. Updated drop zone background color to use Fluent theme variables
  3. Added a transition effect for better visual feedback
  4. Implemented a dragend event listener to ensure proper state reset

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review October 17, 2024 20:52
compulim
compulim previously approved these changes Oct 17, 2024
@compulim
Copy link
Contributor

compulim commented Oct 17, 2024

Just need changelog. 😉

@OEvgeny OEvgeny force-pushed the fix/fluent-dropzone-improvements branch from 0577fa6 to 9eed9f7 Compare October 17, 2024 21:30
@OEvgeny OEvgeny requested a review from compulim October 18, 2024 00:30
@compulim compulim merged commit ae69d04 into main Oct 18, 2024
27 checks passed
@compulim compulim deleted the fix/fluent-dropzone-improvements branch October 18, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants