Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev server #5333

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix dev server #5333

merged 2 commits into from
Oct 25, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 25, 2024

Changelog Entry

(No changelog for dev toolchain change.)

Description

When in the Webpack-era, we were doing: Webpack --file--> esbuild dev server --port 8000--> serve.

In the tsup-era, we only need: tsup --file--> serve.

As tsup is flushing in a streaming way, esbuild is mostly picking up non-fully-flushed file, causing issues.

Design

Removed the intermediary esbuild dev server.

Specific Changes

  • Removed packages/bundle/scripts/devServer.mjs
  • Updated bundle/package.json script to remove esbuild dev server
  • Updated packages/test/devServer/src/index.mjs to serve webchat* from packages/bundle/dist/ directly
  • Removed unused packages: chalk and http-proxy-middleware
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • kAccessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review October 25, 2024 18:54
Copy link
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@OEvgeny OEvgeny merged commit e6bfd8a into microsoft:main Oct 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants