Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
(No changelog for dev toolchain change.)
Description
When in the Webpack-era, we were doing: Webpack --file--> esbuild dev server --port 8000--> serve.
In the tsup-era, we only need: tsup --file--> serve.
As tsup is flushing in a streaming way, esbuild is mostly picking up non-fully-flushed file, causing issues.
Design
Removed the intermediary esbuild dev server.
Specific Changes
packages/bundle/scripts/devServer.mjs
bundle/package.json
script to remove esbuild dev serverpackages/test/devServer/src/index.mjs
to servewebchat*
frompackages/bundle/dist/
directlychalk
andhttp-proxy-middleware
I have added tests and executed them locallyI have updatedCHANGELOG.md
I have updated documentationReview Checklist
kAccessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)