-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add syntax highlighting into markdown code block #5389
Open
OEvgeny
wants to merge
27
commits into
main
Choose a base branch
from
feature/code-block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
commented
Dec 4, 2024
...led-inputs-js-accessibility-requirement-disabling-adaptive-card-with-inputs-field-3-snap.png
Outdated
Show resolved
Hide resolved
OEvgeny
commented
Dec 4, 2024
...ent-theme-applied-dark-theme-applied-side-by-side-left-transcript-right-codeblock-3-snap.png
Outdated
Show resolved
Hide resolved
OEvgeny
force-pushed
the
feature/code-block
branch
from
December 5, 2024 17:21
8ed4c58
to
c9e6f63
Compare
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
December 5, 2024 18:10
compulim
reviewed
Dec 5, 2024
...__/html/transcript-activity-grouping-js-transcript-with-activity-grouping-test-43-1-snap.png
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
packages/component/src/Attachment/Text/private/ActivityViewCodeButton.tsx
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 5, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 5, 2024
compulim
reviewed
Dec 5, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlockCopyButton.tsx
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/customElements/CodeBlock.ts
Show resolved
Hide resolved
compulim
reviewed
Dec 11, 2024
packages/component/src/providers/CustomElements/private/useUpdater.tsx
Outdated
Show resolved
Hide resolved
…/CodeBlock.ts Co-authored-by: William Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
This enhances code block rendering in markdown by leveraging custom elements architecture to provide better integration between React components and markdown output. This enables direct property binding and updates to
custom elements (code block, copy button).
Key improvements:
useUpdater
hook to handle communication between React and custom elementsDesign
The implementation follows Web Chat's composer pattern for consistency:
CodeBlock
custom element handles the core rendering and updatesShikiComposer
manages highlighting configurationuseUpdater
hook provides synchronization between React state and custom element updatesMoving highlights configuration to bundle package to align with Web Chat's architecture.
Specific Changes
CodeBlock
custom element with support for theme and language attributesShikiComposer
to bundle package for centralized highlight managementuseUpdater
hook for managing React-to-custom-element state updatesCHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed