DirectMLX.h Split fix a tiny bug which caused by variable 'axisSizeSum' set but not used #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtsai
suggested changes
Apr 5, 2022
| @@ -2342,7 +2341,14 @@ namespace dml | |||
| axisSizeSum += outputAxisSize; | |||
There was a problem hiding this comment.
Won't this now fail to compile?
There was a problem hiding this comment.
Concur, as I see axisSizeSum being used on line 2342.
There was a problem hiding this comment.
Issue #220 describes the detailed error log. TheaxisSizeSum used in 2342 only be assignment for the newer clang. The axisSizeSum only be used for assert statement on line 2345.
There was a problem hiding this comment.
Line 2341 should be deleted now.
| @@ -2342,7 +2341,14 @@ namespace dml | |||
| axisSizeSum += outputAxisSize; | |||
| } | |||
|
|
|||
| #if defined(_DEBUG) | |||
| uint32_t axisSizeSum = 0; | |||
fdwr
changed the title
fdwr
reviewed
Jun 25, 2022
| @@ -2342,7 +2341,14 @@ namespace dml | |||
| axisSizeSum += outputAxisSize; | |||
| } | |||
|
|
|||
| #if defined(_DEBUG) | |||
There was a problem hiding this comment.
#ifndef NDEBUG would be better here, since NDEBUG corresponds for C-style assertions, and _DEBUG is a non-standard macro defined by Visual Studio, but not necessarily other compilers. Also you'll need to delete line 2341.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.