Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of unreferenced variables #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removal of unreferenced variables #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Libraries/DirectMLX.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2148,8 +2148,6 @@ namespace dml

TensorDesc inputTensor = input.Impl()->GetOutputDesc();
const uint32_t defaultStridesAndDilations[3] = { 1, 1, 1 };
uint32_t dimensionCount = static_cast<uint32_t>(inputTensor.sizes.size());
uint32_t spatialDimensionCount = dimensionCount - 2;
Comment on lines -2151 to -2152
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. I see that spatialDimensionCount is used in an assert under the #if DML_TARGET_VERSION > 0x6200 macro block. Instead of deleting, these lines should be moved just above the assert.


#if DML_TARGET_VERSION >= 0x6200
DML_AVERAGE_POOLING1_OPERATOR_DESC averagePoolDesc = {};
Expand Down