Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops .net7 as a target #513

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Drops .net7 as a target #513

merged 4 commits into from
Oct 31, 2024

Conversation

rossgrambo
Copy link
Contributor

Why this PR?

  • Removes .net7 as it's out of support. Keeping .net6 for now to help adoption- although it will be out of support soon.
  • Adds .net9 as a target for tests and asp.net
  • Adds a missing readonly

Visible Changes

  • No visible changes- although we will no longer run tests directly on .net 7. Once .net 6 is removed- customers using .net6 or .net7 will be unable to use the library.

@rossgrambo rossgrambo merged commit 2c94bdf into main Oct 31, 2024
3 checks passed
WeihanLi
WeihanLi reviewed Nov 8, 2024
View reviewed changes
build/install-dotnet.ps1
@@ -7,4 +7,6 @@

&([scriptblock]::Create((Invoke-WebRequest -UseBasicParsing 'https://dot.net/v1/dotnet-install.ps1'))) -Channel 7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 7.0 be removed since we drop net7 target

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeihanLi WeihanLi WeihanLi left review comments

@avanigupta avanigupta avanigupta approved these changes

@zhiyuanliang-ms zhiyuanliang-ms Awaiting requested review from zhiyuanliang-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossgrambo @avanigupta @WeihanLi