fix(test-version-utils): Fix version calculation to account for legacy breaking minor releases #23603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
No objections to this change, really, but I think Sonali wrote some similar code in #22687. Might be worth a look to see if we can consolidate some logic. |
Thanks for bringing this to my attention! I looked into it and unfortunately it does not support going back to internal/RC releases which is required in this scenario. Maybe when we look into long term fixes we can merge the logic |
alexvy86
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes N-X version calculation to take into account the new legacy breaking minor releases. For example,
2.0.0 <= N < 2.10.0, N-1 is 2.0.0-rc.5.0.x.2.10.0 <= N < 2.20.0, N-1 is 2.5.x (latest minor between 2.0 and 2.10 is 2.5.x)2.20.0 <= N < 2.30.0, N-1 is 2.13.x (latest minor between 2.10 and 2.20 is 2.13.x)We should still consider a full rewrite of version calculation, since the code is extremely messy and hard to follow for developers not familiar with it already. However, this change is needed to ensure we continue testing properly in the meantime. See AB#8198 for more details.
AB#28437