Improved Error Handling when Connecting to Exchange with Managed Identity (#186) #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve error handling and code clarity in the
MSCloudLoginAssistant
module. The most important changes include adding try-catch blocks to handle potential exceptions, improving verbose logging, and updating conditional checks for string values.Error Handling Improvements:
Modules/MSCloudLoginAssistant/MSCloudLoginAssistant.psm1
: Added try-catch blocks to handleCommandNotFoundException
and other exceptions when retrieving the initial domain usingGet-MgDomain
orGet-MgBetaDomain
. This ensures that appropriate error messages are logged when exceptions occur.Logging Enhancements:
Modules/MSCloudLoginAssistant/MSCloudLoginAssistant.psm1
: Enhanced verbose logging to include the exception message when failing to get the domain, providing more context for troubleshooting.Code Clarity:
Modules/MSCloudLoginAssistant/Workloads/ExchangeOnline.psm1
: Updated the conditional check to use[string]::IsNullOrEmpty
for better readability and to handle both null and empty string cases. Additionally, added error handling to log an error message and stop execution if the organization name cannot be retrieved.This PR fixes #186.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)