More updates

microsoft · Oct 28, 2024 · 1043797 · 1043797
1 parent 7e1ea3c
commit 1043797
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 0 deletions.
diff --git a/src/Microsoft.Unity.Analyzers.Tests/EmptyUnityMessageTests.cs b/src/Microsoft.Unity.Analyzers.Tests/EmptyUnityMessageTests.cs
@@ -38,6 +38,48 @@ private void Foo()
 		const string fixedTest = @"
 using UnityEngine;
 
+class Camera : MonoBehaviour
+{
+
+    private void Foo()
+    {
+    }
+}
+";
+		await VerifyCSharpFixAsync(test, fixedTest);
+	}
+
+	[Fact]
+	public async Task AwaitableEmptyFixedUpdate()
+	{
+		const string test = @"
+using UnityEngine;
+
+class Camera : MonoBehaviour
+{
+    // comment expected to be removed
+    private async Awaitable FixedUpdate()
+    {
+    }
+
+    private void Foo()
+    {
+    }
+}
+";
+		var context = AnalyzerVerificationContext
+			.Default
+			.WithAnalyzerFilter("CS1998");
+
+		var diagnostic = ExpectDiagnostic()
+			.WithLocation(7, 29)
+			.WithArguments("FixedUpdate");
+
+		await VerifyCSharpDiagnosticAsync(context, test, diagnostic);
+
+		const string fixedTest = @"
+using UnityEngine;
+
 class Camera : MonoBehaviour
 {
 

diff --git a/src/Microsoft.Unity.Analyzers.Tests/ImproperMessageCaseTests.cs b/src/Microsoft.Unity.Analyzers.Tests/ImproperMessageCaseTests.cs
@@ -60,6 +60,43 @@ private void Update()
 		await VerifyCSharpFixAsync(test, fixedTest);
 	}
 
+	[Fact]
+	public async Task ImproperlyCasedAwaitableUpdate()
+	{
+		const string test = @"
+using UnityEngine;
+
+class Camera : MonoBehaviour
+{
+    private async Awaitable UPDATE()
+    {
+    }
+}
+";
+
+		var context = AnalyzerVerificationContext
+			.Default
+			.WithAnalyzerFilter("CS1998");
+
+		var diagnostic = ExpectDiagnostic()
+			.WithLocation(6, 29)
+			.WithArguments("UPDATE");
+
+		await VerifyCSharpDiagnosticAsync(context, test, diagnostic);
+
+		const string fixedTest = @"
+using UnityEngine;
+
+class Camera : MonoBehaviour
+{
+    private async Awaitable Update()
+    {
+    }
+}
+";
+		await VerifyCSharpFixAsync(test, fixedTest);
+	}
+
 	[Fact]
 	public async Task ImproperlyCasedStaticUpdateIgnored()
 	{
@@ -112,6 +149,48 @@ static bool OnPreGeneratingCSProjectFiles()
 		await VerifyCSharpFixAsync(test, fixedTest);
 	}
 
+	[Fact]
+	public async Task ImproperlyCasedAwaitableRealStaticMessage()
+	{
+		const string test = @"
+using UnityEngine;
+using UnityEditor;
+
+class App : AssetPostprocessor
+{
+    async static Awaitable<bool> OnPREGeneratingCSProjectFiles()
+    {
+        return false;
+    }
+}
+";
+
+		var context = AnalyzerVerificationContext
+			.Default
+			.WithAnalyzerFilter("CS1998");
+
+		var diagnostic = ExpectDiagnostic()
+			.WithLocation(7, 34)
+			.WithArguments("OnPREGeneratingCSProjectFiles");
+
+		await VerifyCSharpDiagnosticAsync(context, test, diagnostic);
+
+		const string fixedTest = @"
+using UnityEngine;
+using UnityEditor;
+
+class App : AssetPostprocessor
+{
+    async static Awaitable<bool> OnPreGeneratingCSProjectFiles()
+    {
+        return false;
+    }
+}
+";
+		await VerifyCSharpFixAsync(test, fixedTest);
+	}
+
+
 	[Fact]
 	public async Task ProperlyCasedOnPostprocessAllAssets()
 	{