Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USP0022, UnityObjectIfNullCoalescingSuppressor #324

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add USP0022, UnityObjectIfNullCoalescingSuppressor #324

merged 1 commit into from
Apr 18, 2024

Conversation

JorisCleVR
Copy link
Contributor

@JorisCleVR JorisCleVR commented Apr 18, 2024 •
edited by sailro
Loading

Fixes #323

Checklist

  • I have read the Contribution Guide ;
  • There is an approved issue describing the change when contributing a new analyzer or suppressor ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

  • IDE0270 is suppressed by the UnityObjectNullHandlingAnalyzer

Changes proposed in this pull request:

  • UnityObjectNullHandlingAnalyzer now supresses IDE0270

@JorisCleVR JorisCleVR requested a review from a team as a code owner April 18, 2024 08:22
@JorisCleVR JorisCleVR mentioned this pull request Apr 18, 2024
Closed
@JorisCleVR
Copy link
Contributor Author

@microsoft-github-policy-service agree company="CleVR"

sailro
sailro approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@sailro sailro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sailro sailro merged commit ba0229d into microsoft:main Apr 18, 2024
6 checks passed
@sailro
Copy link
Member

sailro commented Apr 18, 2024

Thank you @JorisCleVR for this contribution. Perfect !

@JorisCleVR
Copy link
Contributor Author

Your welcome. Thank you for the fast integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sailro sailro sailro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE0270 should be suppressed by the UnityObjectNullHandlingAnalyzer
2 participants
@JorisCleVR @sailro