Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UNT0014 #352

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Refactor UNT0014 #352

merged 2 commits into from
Sep 3, 2024

Conversation

sailro
Copy link
Member

@sailro sailro commented Sep 2, 2024

Fixes #349

Checklist

  • I have read the Contribution Guide ;
  • I have added tests that prove my fix is effective or that my feature works ;
  • I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

Refactor the diagnostic and for consistency:

  • when we know for sure that the usage is invalid, add a diagnostic
  • when we know for sure that the usage is valid, do nothing
  • when we need to infer on usages, do nothing (for now)

See issue for more information.

@sailro sailro requested a review from a team as a code owner September 2, 2024 14:51
@sailro sailro merged commit 1de7746 into main Sep 3, 2024
6 checks passed
@sailro sailro deleted the refactor-UNT0014 branch September 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbevain jbevain jbevain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UNT0014 generics problem with interfaces
2 participants
@sailro @jbevain