Correctly use default error color in the presence of an empty st… (#735)

Correctly use default error color in the presence of an empty string.
microsoft · Nov 15, 2019 · 1d5160e · 1d5160e
2 parents 8bfce29 + fe6c753
commit 1d5160e
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/typescript/listeners/idle.py b/typescript/listeners/idle.py
@@ -162,15 +162,16 @@ def show_errors(self, diagno_event_body, syntactic):
                              sublime.DRAW_OUTLINED)
         else:
             settings = sublime.load_settings("TypeScript.sublime-settings")
+            error_color = settings.get("error_color") or "invalid.illegal"
+            error_icon = settings.get("error_icon") or ""
+            error_draw_style = \
+                sublime.DRAW_OUTLINED if settings.get("error_outlined") \
+                else sublime.DRAW_NO_FILL | sublime.DRAW_NO_OUTLINE | sublime.DRAW_SQUIGGLY_UNDERLINE
             view.add_regions(region_key,
                              error_regions,
-                             settings.get("error_color", "invalid.illegal"),
-                             settings.get("error_icon", ""),
-                             sublime.DRAW_OUTLINED
-                             if settings.get("error_outlined") else
-                             sublime.DRAW_NO_FILL +
-                             sublime.DRAW_NO_OUTLINE +
-                             sublime.DRAW_SQUIGGLY_UNDERLINE)
+                             error_color,
+                             error_icon,
+                             error_draw_style)
 
     def update_status(self, view, info):
         """Update the status line with error info and quick info if no error info"""