Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker: Add ability to pass parent window handle explicitly for Windows broker auth #500

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seclerp
Copy link

@seclerp seclerp commented Jul 8, 2024

We have a headless process that hosts the NuGet credential plugin manager and we are facing issues with the default broker logic which tries to obtain the current process' window handle, as we need to pass a native window handle of another (non-.NET) desktop app process. I think the change will be quite beneficial in such a scenario.

I'm open to discussion in case env-based handle propagation is not the best approach.

@seclerp
Copy link
Author

seclerp commented Jul 8, 2024

@microsoft-github-policy-service agree company="JetBrains"

@seclerp seclerp requested a review from embetten July 9, 2024 09:29
@seclerp
Copy link
Author

seclerp commented Jul 9, 2024

I have a question - what is a proper workflow for internationalization? Should I update the default Resources.resx only?

@seclerp
Copy link
Author

seclerp commented Jul 15, 2024

Hi @embetten, do you need something else from my side, any concerns? Is there something that prevents this stuff from being merged?

@embetten
Copy link
Contributor

I have a question - what is a proper workflow for internationalization? Should I update the default Resources.resx only?

Currently this is not localized. Any strings to be logged should be added there so they will be localized in the future ( #464 )

Hi @embetten, do you need something else from my side, any concerns? Is there something that prevents this stuff from being merged?

Conflict resolutions would be appreciated. The only blocker was our internal validation.

@seclerp seclerp force-pushed the seclerp/explicit-window-handle branch from 0b03278 to 1102e8b Compare September 23, 2024 10:14
Copy link
Contributor

@embetten embetten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants