-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker: Add ability to pass parent window handle explicitly for Windows broker auth #500
base: master
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="JetBrains" |
I have a question - what is a proper workflow for internationalization? Should I update the default |
Hi @embetten, do you need something else from my side, any concerns? Is there something that prevents this stuff from being merged? |
Currently this is not localized. Any strings to be logged should be added there so they will be localized in the future ( #464 )
Conflict resolutions would be appreciated. The only blocker was our internal validation. |
…uthentication method
…REDENTIALPROVIDER_MSAL_BROKER_WINDOW`
0b03278
to
1102e8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
We have a headless process that hosts the NuGet credential plugin manager and we are facing issues with the default broker logic which tries to obtain the current process' window handle, as we need to pass a native window handle of another (non-.NET) desktop app process. I think the change will be quite beneficial in such a scenario.
I'm open to discussion in case env-based handle propagation is not the best approach.