2142647 Update AKS API used to get cluster credentials in AKS tasks #20649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipsonJoseph
requested review from
manolerazvan and
a team
as code owners
|
azp /run |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
onetocny
approved these changes
Nov 13, 2024
manolerazvan
approved these changes
Nov 14, 2024
geekzter
requested changes
Nov 15, 2024
There was a problem hiding this comment.
@PhilipsonJoseph can we add a link to https://aka.ms/azdo-rm-aks-access in case we get an ARM permission issue (403)? I want to prevent customers that created custom RBAC roles from creating support cases. e.g. Cannot fetch the credentials for the cluster %s. Reason %s. Make sure the service connection is assigned an appropriate Azure RBAC role: https://aka.ms/azdo-aks-rm-access.
There are specific roles for user vs admin credentials, and a role that has everything. We can explain that in the doc.
Reverse merge from master :w w
Reverse merge from Master complete
|
Hi @geekzter added URL to the Common lib with PR microsoft/azure-pipelines-tasks-common-packages#410 and updated to tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureFunctionOnKubernetesV1
HelmDeployV0
HelmDeployV1
KubernetesManifestV1
KubernetesV1
Description: New API for fetching credentials are added based on the FF
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist:
#https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2073393