Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter to KubeloginInstallerV0 to authorize request to github to avoid request limits on unauthorized requests #20685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mispencer
Copy link

Task name: KubeloginInstallerV0

Description: This task makes requests to the GitHub API to fetch the url to download. Currently, these requests are unauthorized. However, the GitHub API has low rate limits on unauthorized requests, so these requests can fail which in turn causes the task run to fail. This PR adds a new parameter to allow the user to supply a Github Service Connection that is used to authorize these requests. Authorized requests have a much higher rate limit, thus providing authorization makes this issue much less likely to occur.

Documentation changes required: Y

Added unit tests: N

Attached related issue: (Y/N) #19097

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

…st to github to avoid request limits on unauthorized requests
@mispencer
Copy link
Author

@microsoft-github-policy-service agree company="Tyler Technologies"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant