Update logic for getting package infos and options #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some inefficiencies and confused leftover logic around
getPackageInfosand getting combined package options.It appears that the original intent of beachball was to support per-package JS config files, but that actually hasn't worked since #405. But the docs were outdated on this point, and there was still some leftover code (like unnecessarily using cosmiconfig to read package-level beachball options from package.json). I don't see any immediate need for adding this back (see #1021), so this PR removes the leftovers and updates the docs.
I also noticed that
getPackageInfoswas re-processing the repo and CLI options (or at least calling those methods, which might be cached) once for every package. Refactoring it to only call those once might improve perf slightly.Also due to lack of package-level JS config support, the
PackageOptionslevelchangeFilePromptproperty doesn't make sense (it must be a function). So remove it and read those options from the top level instead.