Add unit test to cover all comments case

microsoft · Feb 2, 2024 · 95ca3fb · 95ca3fb
1 parent 56375bc
commit 95ca3fb
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/AllComments.json b/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/AllComments.json
@@ -0,0 +1,5 @@
+{
+  "sections": [],
+  "content": "> This is a comment\n> This is another comment",
+  "errors": []
+}
diff --git a/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/AllComments.txt b/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/AllComments.txt
@@ -0,0 +1,2 @@
+> This is a comment
+> This is another comment
diff --git a/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/LU_Sections_Unix.json b/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/LU_Sections_Unix.json
@@ -161,11 +161,11 @@
                     "errorMsgs": [
 
                     ],
-                    "contextText": "- Please set {deviceTemperature = thermostat to 72}",
+                    "contextText": "    - Please set {deviceTemperature = thermostat to 72}",
                     "range": {
                         "Start": {
                             "Line": 17,
-                            "Character": 4
+                            "Character": 0
                         },
                         "End": {
                             "Line": 17,

diff --git a/...sers/Microsoft.Bot.Builder.Parsers.LU.Tests/Microsoft.Bot.Builder.Parsers.LU.Tests.csproj b/...sers/Microsoft.Bot.Builder.Parsers.LU.Tests/Microsoft.Bot.Builder.Parsers.LU.Tests.csproj
@@ -20,6 +20,12 @@
     <Folder Include="Parser\" />
   </ItemGroup>
   <ItemGroup>
+    <None Update="Fixtures\AllComments.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Update="Fixtures\AllComments.txt">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Update="Fixtures\ImportAllLu.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

diff --git a/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Parser/LuParserTests.cs b/tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Parser/LuParserTests.cs
@@ -18,6 +18,7 @@ public class LuParserTests
         [InlineData("LU_Sections")]
         [InlineData("SectionsLU")]
         [InlineData("ImportAllLu")]
+        [InlineData("AllComments")]
         public void ParseLuContent(string fileName)
         {
             // var luContent = "# Help"+ Environment.NewLine + "- help" + Environment.NewLine + "- I need help" + Environment.NewLine + "- please help";