Remove unused deprecated adal package #6689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit2nil
changed the title
mit2nil
changed the title
|
We're going to hold on this. There are other alerts coming from the affected test project. This shouldn't not effect anyone consuming BF SDK packages as it's not published as a dependency. It exists only to run unit tests for the Connector package. There is another effort underway to correct this project though. |
|
Hi @tracyboehrer, this PR should solve the compliance blocker in Microsoft.Bot.Connector.Tests. We reviewed the rest of the project and there are no more references to ADAL. |
ceciliaavila
added
the
Automation: No parity
|
@ceciliaavila There is also an alert related to Microsoft.Rest.ClientRuntime.Azure.TestFramework |
|
This was resolved in: #6690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor