Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable failing expired token test in CloudAdapter #6707

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Related microsoft/botbuilder-js#4560

Description

This PR disables the ExpiredTokenShouldThrowUnauthorizedAccessException test due to invalid SigningKey value in the token. This will be skipped for now until a fix is provided, so it doesn't block new PR merges.

@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Nov 21, 2023
@sw-joelmut sw-joelmut requested a review from a team as a code owner November 21, 2023 18:14
@sw-joelmut
Copy link
Collaborator Author

Hi @tracyboehrer

There is a unit test failing in main, preventing other PRs to pass. We created this PR to disable it temporarily until we provide a fix.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 377855

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.08%) to 78.438%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/Authentication/JwtTokenExtractor.cs 2 53.85%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.81%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 4 74.47%
/libraries/Microsoft.Bot.Connector/Authentication/JwtTokenValidation.cs 5 56.92%
/libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs 13 32.35%
Totals Coverage Status
Change from base Build 375403: -0.08%
Covered Lines: 26119
Relevant Lines: 33299

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit ae0041a into main Nov 21, 2023
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/skip-expired-token-test branch November 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants