Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AseChannelValidation need throw when appid is not valid. #6721

Merged
merged 12 commits into from
Dec 21, 2023
Merged

fix: AseChannelValidation need throw when appid is not valid. #6721

merged 12 commits into from
Dec 21, 2023

Conversation

fangyangci
Copy link
Contributor

@fangyangci fangyangci commented Dec 21, 2023

Fixes #6719

Description

When the appid is not match, need to throw.

Specific Changes

Throw exception when appID is not valid.

Testing

test locally.

@fangyangci fangyangci requested a review from a team as a code owner December 21, 2023 04:05
@fangyangci fangyangci changed the title fix: a coding mistake in AseChannelValidation fix: AseChannelValidation need throw when appid is not valid. Dec 21, 2023
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Dec 21, 2023
@tracyboehrer tracyboehrer merged commit b6aed8c into microsoft:main Dec 21, 2023
14 of 15 checks passed
tracyboehrer pushed a commit that referenced this pull request Jan 24, 2024
* fixUSGovSingleTenant

* Add UT

* AseChannelValidation

* Add UT

* Rollback AuthTenant Property Name

* The Ctor do contains the old ones, Add Ctor to ApiCompatBaseline

* fix a coding mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Ase Channel Validation
2 participants